Skip to content

QR code, reduce extra adaptiveThreshold()#22659

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
AleksandrPanov:qr_reduce_extra_adaptiveThreshold
Oct 20, 2022
Merged

QR code, reduce extra adaptiveThreshold()#22659
asmorkalov merged 1 commit intoopencv:4.xfrom
AleksandrPanov:qr_reduce_extra_adaptiveThreshold

Conversation

@AleksandrPanov
Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov commented Oct 18, 2022

Pull Request Readiness Checklist

There is already a function adaptiveThreshold call in void QRDecode::init:

adaptiveThreshold(original, bin_barcode, 255, ADAPTIVE_THRESH_GAUSSIAN_C, THRESH_BINARY, 83, 2);

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

@AleksandrPanov Please add benchmark statistics before and after the fix. Unit test is useful too.

@AleksandrPanov AleksandrPanov marked this pull request as ready for review October 20, 2022 08:56
@asmorkalov asmorkalov self-requested a review October 20, 2022 09:04
@asmorkalov asmorkalov self-assigned this Oct 20, 2022
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit e80b443 into opencv:4.x Oct 20, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants