Skip to content

DNN-TF: let StridedSlice layer support const input#22653

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
WanliZhong:issue22597
Oct 21, 2022
Merged

DNN-TF: let StridedSlice layer support const input#22653
asmorkalov merged 1 commit intoopencv:4.xfrom
WanliZhong:issue22597

Conversation

@WanliZhong
Copy link
Copy Markdown
Member

@WanliZhong WanliZhong commented Oct 18, 2022

This PR try to fix #22597.
Continue the work of #22628 due to branch name is incorrect.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@WanliZhong WanliZhong added category: dnn pr: needs test New functionality requires minimal tests set labels Oct 18, 2022
@WanliZhong
Copy link
Copy Markdown
Member Author

WanliZhong commented Oct 19, 2022 •
edited
Loading

My solution is to create a new virtual layer, and then we can parse the node as normal. I have tested this change and it parses the node shown below correctly. Since the corresponding test model is not easy to generate, can we just merge this PR?
image

@WanliZhong WanliZhong marked this pull request as ready for review October 19, 2022 07:16
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Oct 20, 2022

@WanliZhong Please add test for the fix.

@asmorkalov asmorkalov requested a review from rogday October 20, 2022 07:05
@WanliZhong
Copy link
Copy Markdown
Member Author

WanliZhong commented Oct 20, 2022

@asmorkalov The test model should have a node with const input. I can't generate the model, but I have debug for this situation. So I'm wondering if this PR can be merged without testing?

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Oct 20, 2022

@rogday What do you think?

@WanliZhong
Copy link
Copy Markdown
Member Author

WanliZhong commented Oct 20, 2022 •
edited
Loading

@rogday What do you think?

He left a comment in the PR I have closed. #22628 (comment)

@rogday
Copy link
Copy Markdown
Member

rogday commented Oct 20, 2022

Does this work?

@WanliZhong
Copy link
Copy Markdown
Member Author

WanliZhong commented Oct 21, 2022

@rogday This is the model I have generated for test: new_model.zip. But I can't put it into opencv_extra because it has no input data and output data.

rogday
rogday approved these changes Oct 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this without test.

@asmorkalov asmorkalov removed the pr: needs test New functionality requires minimal tests set label Oct 21, 2022
@asmorkalov asmorkalov merged commit e4cd430 into opencv:4.x Oct 21, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
@WanliZhong WanliZhong deleted the issue22597 branch May 16, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rogday rogday rogday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rogday rogday

Labels

category: dnn

Projects

None yet

Milestone

4.7.0

3 participants

@WanliZhong @asmorkalov @rogday