Reset cuda runtime error code to cudasuccess on runtime failure.#22633
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Oct 26, 2022
Merged
Reset cuda runtime error code to cudasuccess on runtime failure.#22633asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
asenyaev
approved these changes
Oct 18, 2022
Contributor
asenyaev
left a comment
There was a problem hiding this comment.
Tested on my side:
Run xvfb-run -a bin/opencv_test_cudaarithm
[==========] 11340 tests from 68 test cases ran. (7284 ms total)
[ PASSED ] 11340 tests
6 tasks
4 tasks
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for opencv/opencv_contrib#3361.
When a cuda runtime/driver function returns an error code which generates an OpenCV exception that code is not cleared so any subsequent calls to
cudaGetLastError();will return it. This means any future functions which callcudaSafeCall(cudaGetLastError())or similar macros can throw an exception from this error as described in opencv/opencv_contrib#3361.As OpenCV does not expose a method for clearing this error it seems reasonable that it would be the responsibility of the OpenCV lib to automatically clear it when it throws and exception. If this is valid fix, it should probably also be applied to the macro in the contrib repo aswell.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.