Opencv.js: on imread add willReadFrequently to getContext#22613
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Oct 11, 2022
Merged
Opencv.js: on imread add willReadFrequently to getContext#22613asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
asmorkalov
approved these changes
Oct 11, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On opencv.js,
cv.imreadon a canvas element first gets the 2d context bygetContext('2d').This produces the warning on Chrome (and other webkit browsers):
The link: https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently
The correct syntax: https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/getContext#syntax
The compatibility: https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/getContext#browser_compatibility
In this PR i added the
willReadFrequentlyattribute and checked on Chrome (compatible), Safari (not compatible) and other browsers.On compatible browsers the warning is avoided and
imreadshould work faster.On non-compatible browsers the change has no effect and
imreadworks as before.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.