Skip to content

add cvGetPropVisible_COCOA#22601

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
cpoerschke:4.x-issue-22595
Oct 30, 2022
Merged

add cvGetPropVisible_COCOA#22601
opencv-pushbot merged 1 commit intoopencv:4.xfrom
cpoerschke:4.x-issue-22595

Conversation

@cpoerschke
Copy link
Copy Markdown
Contributor

naive fix for the #22595 issue.

tested 'not visible' behaviour via cv::waitKey(12345); and minimising the window during that wait.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from VadimLevin October 6, 2022 16:32
@asmorkalov asmorkalov removed the request for review from VadimLevin October 17, 2022 06:40
@opencv-pushbot opencv-pushbot merged commit 87360c2 into opencv:4.x Oct 30, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
@LaurentBerger
Copy link
Copy Markdown
Contributor

LaurentBerger commented Apr 5, 2024

@cpoerschke I think you know cocoa better than me. When you open a window using imshow there is no close box in C++. Can you confirm? (there is close box in windows and wsl2)

@cpoerschke
Copy link
Copy Markdown
Contributor Author

... When you open a window using imshow there is no close box in C++. Can you confirm? (there is close box in windows and wsl2)

Yes, the red close box is no longer there for me too but it used to be there I think ... from a little experimentation NSClosableWindowMask|NSMiniaturizableWindowMask instead of NSMiniaturizableWindowMask shows the box ... however I'm not sure if the behaviour on closing then is like it used to be e.g. cv::waitKey(0) seems to continue to wait and perhaps it should not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with getWindowProperty(cv::WND_PROP_VISIBLE)

4 participants