Merged
Conversation
6 tasks
3af29bd to
374c40d
Compare
374c40d to
3a15152
Compare
VadimLevin
approved these changes
Nov 30, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This bug happens when try to generate python-bindings for a function which takes
cv::Vecas default arguments.For example, I designed a function randomCrop which takes
paddingof dtypecv::Vec4ias default argument:When I trying to generate python-binding for this function, nothing wrong happens.
But when the user use this function in python environment, and they treat
paddingas default argument so they don't pass value for this argument. They may call this function like this:Then wired thing happens, the python generator calls
pyopencv_toon line 63 ofcv2_convert.hpp, trying to convert the python object intoVec4i. But this functionpyopencv_toomit the case when this argument has default value and user passes no value for it. In this case, the function trying to copy a None objecttmpto the targetmx, which will raise error in thecopyToprocedure.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.