Skip to content

DNN: Remove unused code in onnx_importer.cpp#22585

Merged
asmorkalov merged 1 commit into4.xfrom
zm/remove-code-1
Sep 29, 2022
Merged

DNN: Remove unused code in onnx_importer.cpp#22585
asmorkalov merged 1 commit into4.xfrom
zm/remove-code-1

Conversation

@zihaomu
Copy link
Copy Markdown
Member

@zihaomu zihaomu commented Sep 29, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@zihaomu zihaomu requested a review from rogday September 29, 2022 02:54
@zihaomu zihaomu added the category: dnn (onnx) ONNX suport issues in DNN module label Sep 29, 2022
@asmorkalov asmorkalov requested review from asmorkalov and removed request for rogday September 29, 2022 07:34
@asmorkalov asmorkalov self-assigned this Sep 29, 2022
@asmorkalov asmorkalov added this to the 4.7.0 milestone Sep 29, 2022
asmorkalov
asmorkalov approved these changes Sep 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@asmorkalov asmorkalov merged commit c8c29b0 into 4.x Sep 29, 2022
@zihaomu zihaomu deleted the zm/remove-code-1 branch September 29, 2022 08:48
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: dnn (onnx) ONNX suport issues in DNN module

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zihaomu @asmorkalov