Skip to content

DNN: add enableWinograd API for Net#22577

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
zihaomu:Disable_winograd_branch_in_tryquantize
Oct 11, 2022
Merged

DNN: add enableWinograd API for Net#22577
asmorkalov merged 1 commit intoopencv:4.xfrom
zihaomu:Disable_winograd_branch_in_tryquantize

Conversation

@zihaomu
Copy link
Copy Markdown
Member

@zihaomu zihaomu commented Sep 27, 2022

Two task in the PR:

  1. add enableWinograd API for Net
  2. disable Winograd branch in try quantize func.

Winograd Convolution will effect the accuracy, which may lead to more errors in the calibration process of DNN on-fly-quantize (net.quantize()). This PR wants to disable the Winograd branch in convolution computation.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@zihaomu zihaomu requested a review from vpisarev September 27, 2022 04:29
@asmorkalov asmorkalov requested a review from rogday September 27, 2022 09:44
@zihaomu zihaomu linked an issue Sep 28, 2022 that may be closed by this pull request
@zihaomu zihaomu linked an issue Sep 28, 2022 that may be closed by this pull request
@zihaomu zihaomu changed the title DNN: disable winograd branch in try quantize func. DNN: add enableHighPrecision API for Net and disable winograd branch in try quantize func. Sep 28, 2022
@zihaomu zihaomu changed the title DNN: add enableHighPrecision API for Net and disable winograd branch in try quantize func. DNN: add enableHighPrecision API for Net Sep 28, 2022
@zihaomu zihaomu mentioned this pull request Oct 1, 2022
6 tasks
@zihaomu zihaomu changed the title DNN: add enableHighPrecision API for Net DNN: add enableWinograd API for Net Oct 8, 2022
@zihaomu zihaomu force-pushed the Disable_winograd_branch_in_tryquantize branch 2 times, most recently from b4a5420 to 85b6737 Compare October 8, 2022 07:17
@zihaomu zihaomu force-pushed the Disable_winograd_branch_in_tryquantize branch from 85b6737 to 1e2ceca Compare October 9, 2022 01:34
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 👍

@asmorkalov asmorkalov merged commit ec26541 into opencv:4.x Oct 11, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API Discussion about DNN precision

4 participants