Skip to content

Add bindings to CUDA photo denoising functions#22562

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
cudawarped:add_bindings_to_cuda_fastNlMeansDenoising
Oct 7, 2022
Merged

Add bindings to CUDA photo denoising functions#22562
asmorkalov merged 1 commit intoopencv:4.xfrom
cudawarped:add_bindings_to_cuda_fastNlMeansDenoising

Conversation

@cudawarped
Copy link
Copy Markdown
Contributor

@cudawarped cudawarped commented Sep 23, 2022

Python bindings were missing from the CUDA photo denoising functions. The function signatures have been updated and python test added to verify their existence.

Are these supposed to be in the main repository?

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@cudawarped
Copy link
Copy Markdown
Contributor Author

cudawarped commented Sep 23, 2022 •
edited
Loading

This needs futher testing.

alalek
alalek reviewed Sep 24, 2022
View reviewed changes
@cudawarped
Copy link
Copy Markdown
Contributor Author

cudawarped commented Sep 25, 2022

Should these routines be moved to the contrib repo?

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 26, 2022

Tried with Ubuntu 18.04 and CUDA 10.2. Works well on my side.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 30, 2022

Thanks a lot for the contribution! Could you squash commits to have clean history in upstream repo.

@asmorkalov asmorkalov self-requested a review September 30, 2022 07:18
@cudawarped cudawarped force-pushed the add_bindings_to_cuda_fastNlMeansDenoising branch from 192e4be to 8baf46c Compare September 30, 2022 09:32
asmorkalov
asmorkalov approved these changes Oct 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Oct 3, 2022

@alalek Do you have any remarks for the PR?

@asmorkalov asmorkalov merged commit 3d350a0 into opencv:4.x Oct 7, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

No one assigned

Labels

category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib category: photo category: python bindings feature

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cudawarped @asmorkalov @alalek