Fix v_signmask for RISC-V Vector#22558
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Sep 25, 2022
Merged
Conversation
vpisarev
approved these changes
Sep 23, 2022
Contributor
|
@hanliutong thanks for the fix. Could you squash commits before megre? |
1b7294e to
df24bd2
Compare
Contributor
Author
|
@asmorkalov Commits are squashed now. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original signmask implementation returned incorrect results in some cases (e.g. new test cases, 242 is returned but 2 is expected).
This is due to Vector Tail Agnostic in RVV, and this patch solves the problem by using "bitwise AND" to mask high bit.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.