Detect RISC-V compiler from PATH environment variable by dkurt · Pull Request #22547 · opencv/opencv

dkurt · 2022-09-21T08:43:31Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

from https://github.com/riscv-collab/riscv-gnu-toolchain, default install path is /opt/riscv and they recommend add it to the PATH variable.

asmorkalov · 2022-09-21T10:38:31Z

/cc @hanliutong

Incarnation-p-lee · 2022-11-09T10:27:24Z

As I understand, if I pass -DCMAKE_C_COMPILER=xxx and -DCMAKE_CXX_COMPILER from the cmake cmd line, it should work well as expected, right? For example as below.

cmake -DCMAKE_TOOLCHAIN_FILE=../platforms/linux/riscv64-gcc.toolchain.cmake \
  -DCMAKE_C_COMPILER=/home/pli/bin/gnu-rv64-linux/bin/riscv64-unknown-linux-gnu-gcc \
  -DCMAKE_CXX_COMPILER=/home/pli/bin/gnu-rv64-linux/bin/riscv64-unknown-linux-gnu-g++ \
  ../

dkurt · 2022-11-09T11:03:16Z

@Incarnation-p-lee, yes, that should work.

Incarnation-p-lee · 2022-11-09T11:19:52Z

Looks the variables were unset by accident, see the below logs. Finally, it will have errors like

CMake Error at /home/pli/repos/riscv/libraries/opencv/platforms/linux/riscv64-gcc.toolchain.cmake:18 (get_filename_component):
  get_filename_component called with incorrect number of arguments
Call Stack (most recent call first):
  /home/pli/repos/riscv/libraries/opencv/__BUILD/CMakeFiles/3.22.1/CMakeSystem.cmake:6 (include)
  /home/pli/repos/riscv/libraries/opencv/__BUILD/CMakeFiles/CMakeTmp/CMakeLists.txt:3 (project)

>> cmake -DCMAKE_TOOLCHAIN_FILE=../platforms/linux/riscv64-gcc.toolchain.cmake -DCMAKE_C_COMPILER=/home/pli/bin/gnu-rv64-linux/bin/riscv64-unknown-linux-gnu-gcc -DCMAKE_CXX_COMPILER=/home/pli/bin/gnu-rv64-linux/bin/[28/11710]
known-linux-gnu-g++ ../ --debug-output
Running with debug output on.
/home/pli/bin/gnu-rv64-linux/bin/riscv64-unknown-linux-gnu-gcc
   Called from: [3]     /home/pli/repos/riscv/libraries/opencv/platforms/linux/riscv64-gcc.toolchain.cmake
                [2]     /home/pli/repos/riscv/libraries/opencv/__BUILD/CMakeFiles/3.22.1/CMakeSystem.cmake
                [1]     /home/pli/repos/riscv/libraries/opencv/CMakeLists.txt
/home/pli/bin/gnu-rv64-linux/bin/riscv64-unknown-linux-gnu-g++
   Called from: [3]     /home/pli/repos/riscv/libraries/opencv/platforms/linux/riscv64-gcc.toolchain.cmake
                [2]     /home/pli/repos/riscv/libraries/opencv/__BUILD/CMakeFiles/3.22.1/CMakeSystem.cmake
                [1]     /home/pli/repos/riscv/libraries/opencv/CMakeLists.txt
CMake Warning (dev) at /usr/share/cmake-3.22/Modules/CMakeDetermineCompiler.cmake:143 (set):
  Policy CMP0126 is not set: set(CACHE) does not remove a normal variable of
  the same name.  Run "cmake --help-policy CMP0126" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  For compatibility with older versions of CMake, normal variable
  "CMAKE_CXX_COMPILER" will be removed from the current scope.
Call Stack (most recent call first):
  /usr/share/cmake-3.22/Modules/CMakeDetermineCXXCompiler.cmake:66 (_cmake_find_compiler_path)
  CMakeLists.txt:113 (enable_language)
This warning is for project developers.  Use -Wno-dev to suppress it.

   Called from: [3]     /usr/share/cmake-3.22/Modules/CMakeDetermineCompiler.cmake                                                                                                                                                               [2]     /usr/share/cmake-3.22/Modules/CMakeDetermineCXXCompiler.cmake
                [1]     /home/pli/repos/riscv/libraries/opencv/CMakeLists.txt                                                                                                                                                    -- The CXX compiler identification is GNU 12.2.0
   Called from: [3]     /usr/share/cmake-3.22/Modules/CMakeDetermineCompilerId.cmake                                                                                                                                                             [2]     /usr/share/cmake-3.22/Modules/CMakeDetermineCXXCompiler.cmake
                [1]     /home/pli/repos/riscv/libraries/opencv/CMakeLists.txt
CMake Warning (dev) at /usr/share/cmake-3.22/Modules/CMakeDetermineCompiler.cmake:143 (set):
  Policy CMP0126 is not set: set(CACHE) does not remove a normal variable of
  the same name.  Run "cmake --help-policy CMP0126" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  For compatibility with older versions of CMake, normal variable
  "CMAKE_C_COMPILER" will be removed from the current scope.
Call Stack (most recent call first):
  /usr/share/cmake-3.22/Modules/CMakeDetermineCCompiler.cmake:68 (_cmake_find_compiler_path)
  CMakeLists.txt:113 (enable_language)
This warning is for project developers.  Use -Wno-dev to suppress it.

   Called from: [3]     /usr/share/cmake-3.22/Modules/CMakeDetermineCompiler.cmake
                [2]     /usr/share/cmake-3.22/Modules/CMakeDetermineCCompiler.cmake
                [1]     /home/pli/repos/riscv/libraries/opencv/CMakeLists.txt
-- The C compiler identification is GNU 12.2.0
   Called from: [3]     /usr/share/cmake-3.22/Modules/CMakeDetermineCompilerId.cmake
                [2]     /usr/share/cmake-3.22/Modules/CMakeDetermineCCompiler.cmake
                [1]     /home/pli/repos/riscv/libraries/opencv/CMakeLists.txt
-- Check for working CXX compiler: /home/pli/bin/gnu-rv64-linux/bin/riscv64-unknown-linux-gnu-g++
   Called from: [3]     /usr/share/cmake-3.22/Modules/CMakeTestCompilerCommon.cmake
                [2]     /usr/share/cmake-3.22/Modules/CMakeTestCXXCompiler.cmake
                [1]     /home/pli/repos/riscv/libraries/opencv/CMakeLists.txt
CMAKE_C_COMPILER-NOTFOUND
   Called from: [2]     /usr/share/cmake-3.22/Modules/CMakeTestCXXCompiler.cmake
                [1]     /home/pli/repos/riscv/libraries/opencv/CMakeLists.txt
CMAKE_CXX_COMPILER-NOTFOUND

dkurt · 2022-11-09T11:48:50Z

@Incarnation-p-lee, can you please try with -DCMAKE_TOOLCHAIN_FILE=../platforms/linux/riscv64-gnu.toolchain.cmake?

Incarnation-p-lee · 2022-11-09T12:14:46Z

@dkurt Sure, but almost the same.

>> cmake -DCMAKE_TOOLCHAIN_FILE=../platforms/linux/riscv64-gnu.toolchain.cmake -DCMAKE_C_COMPILER=/home/pli/bin/gnu-rv64-linux/bin/riscv64-unknown-linux-gnu-gcc -DCMAKE_CXX_COMPILER=/home/pli/bin/gnu-rv64-linux/bin/riscv64-un
known-linux-gnu-g++ ../ --debug-output
Running with debug output on.
/home/pli/bin/gnu-rv64-linux/bin/riscv64-unknown-linux-gnu-gcc
   Called from: [3]     /home/pli/repos/riscv/libraries/opencv/platforms/linux/riscv64-gcc.toolchain.cmake
                [2]     /home/pli/repos/riscv/libraries/opencv/__BUILD/CMakeFiles/3.22.1/CMakeSystem.cmake
                [1]     /home/pli/repos/riscv/libraries/opencv/CMakeLists.txt
/home/pli/bin/gnu-rv64-linux/bin/riscv64-unknown-linux-gnu-g++
   Called from: [3]     /home/pli/repos/riscv/libraries/opencv/platforms/linux/riscv64-gcc.toolchain.cmake
                [2]     /home/pli/repos/riscv/libraries/opencv/__BUILD/CMakeFiles/3.22.1/CMakeSystem.cmake
                [1]     /home/pli/repos/riscv/libraries/opencv/CMakeLists.txt
CMake Warning (dev) at /usr/share/cmake-3.22/Modules/CMakeDetermineCompiler.cmake:143 (set):
  Policy CMP0126 is not set: set(CACHE) does not remove a normal variable of
  the same name.  Run "cmake --help-policy CMP0126" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  For compatibility with older versions of CMake, normal variable
  "CMAKE_CXX_COMPILER" will be removed from the current scope.
Call Stack (most recent call first):
  /usr/share/cmake-3.22/Modules/CMakeDetermineCXXCompiler.cmake:66 (_cmake_find_compiler_path)
  CMakeLists.txt:113 (enable_language)
This warning is for project developers.  Use -Wno-dev to suppress it.

   Called from: [3]     /usr/share/cmake-3.22/Modules/CMakeDetermineCompiler.cmake                                                                                                                                                               [2]     /usr/share/cmake-3.22/Modules/CMakeDetermineCXXCompiler.cmake
                [1]     /home/pli/repos/riscv/libraries/opencv/CMakeLists.txt
-- The CXX compiler identification is GNU 12.2.0
   Called from: [3]     /usr/share/cmake-3.22/Modules/CMakeDetermineCompilerId.cmake
                [2]     /usr/share/cmake-3.22/Modules/CMakeDetermineCXXCompiler.cmake
                [1]     /home/pli/repos/riscv/libraries/opencv/CMakeLists.txt
CMake Warning (dev) at /usr/share/cmake-3.22/Modules/CMakeDetermineCompiler.cmake:143 (set):
  Policy CMP0126 is not set: set(CACHE) does not remove a normal variable of
  the same name.  Run "cmake --help-policy CMP0126" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  For compatibility with older versions of CMake, normal variable
  "CMAKE_C_COMPILER" will be removed from the current scope.
Call Stack (most recent call first):
  /usr/share/cmake-3.22/Modules/CMakeDetermineCCompiler.cmake:68 (_cmake_find_compiler_path)
  CMakeLists.txt:113 (enable_language)
This warning is for project developers.  Use -Wno-dev to suppress it.

alalek · 2022-11-09T23:43:27Z

platforms/linux/riscv64-gcc.toolchain.cmake:18 (get_filename_component):
get_filename_component called with incorrect number of arguments

There is no line 18 with get_filename_component() in this file.

So,

remove custom patches or provide them if you want help
always clean your build directory if you modify configuration

The last message doesn't contain any error message. See item 2

Can't reproduce:

cmake -GNinja ${OPENCV_SRC_DIR} -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE=${OPENCV_SRC_DIR}/platforms/linux/riscv64-gcc.toolchain.cmake -DCMAKE_C_COMPILER=/home/alalek/projects/riscv/sc-ide/riscv-gcc/bin/riscv64-unknown-linux-gnu-gcc -DCMAKE_CXX_COMPILER=/home/alalek/projects/riscv/sc-ide/riscv-gcc/bin/riscv64-unknown-linux-gnu-g++ -DBUILD_SHARED_LIBS=OFF -DBUILD_WITH_DEBUG_INFO=ON -DCPU_BASELINE=
-- The CXX compiler identification is GNU 12.1.1
-- The C compiler identification is GNU 12.1.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /home/alalek/projects/riscv/sc-ide/riscv-gcc/bin/riscv64-unknown-linux-gnu-g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /home/alalek/projects/riscv/sc-ide/riscv-gcc/bin/riscv64-unknown-linux-gnu-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
...

(riscv64-gcc.toolchain.cmake is patched: -march=rv64gcv_zfh replaced to -march=rv64gc to drop RVV 1.0 requirement)

Incarnation-p-lee · 2022-11-10T01:11:17Z

platforms/linux/riscv64-gcc.toolchain.cmake:18 (get_filename_component):
get_filename_component called with incorrect number of arguments

There is no line 18 with get_filename_component() in this file.

So,

remove custom patches or provide them if you want help

always clean your build directory if you modify configuration

The last message doesn't contain any error message. See item 2

Can't reproduce:
cmake -GNinja ${OPENCV_SRC_DIR} -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE=${OPENCV_SRC_DIR}/platforms/linux/riscv64-gcc.toolchain.cmake -DCMAKE_C_COMPILER=/home/alalek/projects/riscv/sc-ide/riscv-gcc/bin/riscv64-unknown-linux-gnu-gcc -DCMAKE_CXX_COMPILER=/home/alalek/projects/riscv/sc-ide/riscv-gcc/bin/riscv64-unknown-linux-gnu-g++ -DBUILD_SHARED_LIBS=OFF -DBUILD_WITH_DEBUG_INFO=ON -DCPU_BASELINE=
-- The CXX compiler identification is GNU 12.1.1
-- The C compiler identification is GNU 12.1.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /home/alalek/projects/riscv/sc-ide/riscv-gcc/bin/riscv64-unknown-linux-gnu-g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /home/alalek/projects/riscv/sc-ide/riscv-gcc/bin/riscv64-unknown-linux-gnu-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
...
(riscv64-gcc.toolchain.cmake is patched: -march=rv64gcv_zfh replaced to -march=rv64gc to drop RVV 1.0 requirement)

Just add some message to that file which results in the line number change. It works well when given -GNinja, thank you!

Detect RISC-V compiler from PATH environment variable

e0b21dc

dkurt added the category: build/install label Sep 21, 2022

asmorkalov added the platform: riscv label Sep 21, 2022

asmorkalov self-requested a review September 21, 2022 13:07

asmorkalov self-assigned this Sep 21, 2022

asmorkalov merged commit 71ae1ca into opencv:4.x Sep 21, 2022

dkurt deleted the riscv_toolchain branch September 21, 2022 13:20

alalek mentioned this pull request Sep 26, 2022

riscv: use /opt/riscv path in toolchain #22570

Merged

alalek mentioned this pull request Jan 8, 2023

(5.x) Merge 4.x #23113

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Detect RISC-V compiler from PATH environment variable#22547

Detect RISC-V compiler from PATH environment variable#22547
asmorkalov merged 1 commit intoopencv:4.xfrom
dkurt:riscv_toolchain

dkurt commented Sep 21, 2022

Uh oh!

asmorkalov commented Sep 21, 2022

Uh oh!

Incarnation-p-lee commented Nov 9, 2022

Uh oh!

dkurt commented Nov 9, 2022

Uh oh!

Incarnation-p-lee commented Nov 9, 2022

Uh oh!

dkurt commented Nov 9, 2022

Uh oh!

Incarnation-p-lee commented Nov 9, 2022

Uh oh!

alalek commented Nov 9, 2022

Uh oh!

Incarnation-p-lee commented Nov 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

dkurt commented Sep 21, 2022

Pull Request Readiness Checklist

Uh oh!

asmorkalov commented Sep 21, 2022

Uh oh!

Incarnation-p-lee commented Nov 9, 2022

Uh oh!

dkurt commented Nov 9, 2022

Uh oh!

Incarnation-p-lee commented Nov 9, 2022

Uh oh!

dkurt commented Nov 9, 2022

Uh oh!

Incarnation-p-lee commented Nov 9, 2022

Uh oh!

alalek commented Nov 9, 2022

Uh oh!

Incarnation-p-lee commented Nov 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants