[G-API] Pipeline modeling tool - expand performance report#22542
Conversation
|
@smirnov-alexey @dmatveev Folks, could you have a look? |
| << first_run_latency << " ms"; | ||
|
|
||
| ss << name << ": "<< std::endl | ||
| << std::string(2, ' ') << "Warm up time: " << warmup_time << " ms" << std::endl |
There was a problem hiding this comment.
Compilation -> Warm up because it might be confused with OpenVINO model compilation.
|
|
||
| ss << name << ": "<< std::endl | ||
| << std::string(2, ' ') << "Warm up time: " << warmup_time << " ms" << std::endl | ||
| << std::string(2, ' ') << "Elapsed time: " << elapsed << " ms" << std::endl |
There was a problem hiding this comment.
Minor: switch from std::endl to \n
| m_perf.max_latency = utils::max(m_perf.latencies); | ||
| m_perf.first_latency = m_perf.latencies[0]; | ||
|
|
||
| // NB: Count how many executions won't fit to cameta latency iterval |
There was a problem hiding this comment.
iterval -> interval
| const bool drop_frames); | ||
| bool pull(cv::gapi::wip::Data& data) override; | ||
| cv::GMetaArg descr_of() const override; | ||
| double getLatency() const { return m_latency; }; |
There was a problem hiding this comment.
other methods don't have get in their name. Just for consistency
| << first_run_latency << " ms"; | ||
|
|
||
| ss << name << ": \n" | ||
| << std::string(2, ' ') << "Warm up time: " << warmup_time << " ms\n" |
There was a problem hiding this comment.
I believe there are iomanip ways to do padding instead of constructing empty strings... it is about streaming, after all
There was a problem hiding this comment.
Replaced to ' '
| << std::string(4, ' ') << "max: " << max_latency << " ms\n" | ||
| << std::string(4, ' ') << "avg: " << std::fixed << std::setprecision(3) | ||
| << avg_latency << " ms\n" | ||
| << std::string(2, ' ') << "Throughput: " << std::fixed << std::setprecision(3) |
There was a problem hiding this comment.
Also..
Why couldn't you just put those extra spaces into the string literals? You have them anyway, and that way padding would have been seen in the code, too.
|
@TolyaTalamanov Please rebase and fix conflicts. |
a015f0f to
b1d28d5
Compare
Done |
|
@asmorkalov Can it be merged? |
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.