Skip to content

Add an illustration to the homography exercise#22539

Merged
asmorkalov merged 1 commit intoopencv:3.4from
catree:feat_homography_tutorial_gif
Oct 4, 2022
Merged

Add an illustration to the homography exercise#22539
asmorkalov merged 1 commit intoopencv:3.4from
catree:feat_homography_tutorial_gif

Conversation

@catree
Copy link
Copy Markdown
Contributor

@catree catree commented Sep 20, 2022

See #22130

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@catree catree force-pushed the feat_homography_tutorial_gif branch from 42479c0 to 76d12d0 Compare September 20, 2022 11:57
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 20, 2022

As soon as it's illustration, I propose to make the animation several times slower.

@asmorkalov asmorkalov added the category: documentation Documentation fix or update label Sep 20, 2022
@catree catree mentioned this pull request Sep 20, 2022
Closed
6 tasks
@catree
Copy link
Copy Markdown
Contributor Author

catree commented Sep 20, 2022 •
edited
Loading

Ideally, I would prefer to add a link to a YouTube video url (see #22130 (comment)).

A slower gif would take much more disk space.

I was not able to embed a video in the Doxygen.
If it is possible, we could use a video instead of the gif.

@asmorkalov asmorkalov requested a review from vpisarev September 21, 2022 13:08
@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Oct 3, 2022

@catree, thank you for the contribution! I generally agree with @asmorkalov that the gif looks weird (and besides, it takes ~900Kb). I suggest to make it a static picture, just a single frame. I think, it will be a good enough illustration.

vpisarev
vpisarev requested changes Oct 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@vpisarev vpisarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace gif with static image (jpeg)

@catree catree force-pushed the feat_homography_tutorial_gif branch from 76d12d0 to ab5279f Compare October 4, 2022 11:38
@catree
Copy link
Copy Markdown
Contributor Author

catree commented Oct 4, 2022

@vpisarev Done.

@asmorkalov If needed, I can also "backport" these changes to the 4.x branch.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Oct 4, 2022

"backport" to 4.x is not required. I'm working on 3.4 -> 4.x merge right now.

@asmorkalov asmorkalov added this to the 4.7.0 milestone Oct 4, 2022
@vpisarev vpisarev self-requested a review October 4, 2022 12:57
@asmorkalov asmorkalov changed the title Add a gif to the homography exercise Add an illustration to the homography exercise Oct 4, 2022
@asmorkalov asmorkalov merged commit 4a4b2a0 into opencv:3.4 Oct 4, 2022
@alalek alalek mentioned this pull request Oct 15, 2022
Merged
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev vpisarev approved these changes

Assignees

@vpisarev vpisarev

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.19

Development

Successfully merging this pull request may close these issues.

4 participants

@catree @asmorkalov @vpisarev @alalek