Skip to content

G-API: Replace MFX major version assertion to warning#22507

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
TolyaTalamanov:at/replace-mfx-major-version-assert-to-warning
Sep 16, 2022
Merged

G-API: Replace MFX major version assertion to warning#22507
asmorkalov merged 2 commits intoopencv:4.xfrom
TolyaTalamanov:at/replace-mfx-major-version-assert-to-warning

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Sep 12, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@TolyaTalamanov TolyaTalamanov mentioned this pull request Sep 13, 2022
Merged
@TolyaTalamanov TolyaTalamanov force-pushed the at/replace-mfx-major-version-assert-to-warning branch from 66d3e77 to 5ea912e Compare September 13, 2022 07:29
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Sep 13, 2022

@dmatveev Could you have a look, please?
It's blocker for this demo: openvinotoolkit/open_model_zoo#3535

@dmatveev dmatveev added this to the 4.7.0 milestone Sep 15, 2022
dmatveev
dmatveev approved these changes Sep 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this but I believe @sivanov-work should be the gatekeeper here

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Sep 16, 2022

I am ok with this but I believe @sivanov-work should be the gatekeeper here

Yes, we've agreed this change with him.

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Sep 16, 2022

@asmorkalov Could you merge it, please?

@asmorkalov asmorkalov merged commit 1ae8015 into opencv:4.x Sep 16, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@TolyaTalamanov @dmatveev @asmorkalov