Skip to content

Extracted matches_confindece_thresh as stitching matcher parameter.#22505

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
asmorkalov:as/matcher_score_thresh
Oct 1, 2022
Merged

Extracted matches_confindece_thresh as stitching matcher parameter.#22505
opencv-pushbot merged 1 commit intoopencv:4.xfrom
asmorkalov:as/matcher_score_thresh

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Sep 12, 2022 •
edited by alalek
Loading

Fixes #11084

Replacement for #19955

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from alalek September 12, 2022 14:19
@alalek
Copy link
Copy Markdown
Member

alalek commented Sep 12, 2022

Which parameter's value should be used to enable behavior from referenced PR?

@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Sep 13, 2022

matches_confindece_thresh = DOUBLE_MAX.

@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Sep 19, 2022

@alalek Could you take a look on

LINK : warning LNK4098: defaultlib 'LIBCMT' conflicts with use of other libs; use /NODEFAULTLIB:library [C:\build\precommit_windows64\build\modules\imgcodecs\opencv_imgcodecs.vcxproj]

it's not related to the patch IMHO.

@asmorkalov asmorkalov added the need-ci-update CI or Infra update required to merge PR label Sep 23, 2022
@alalek
Copy link
Copy Markdown
Member

alalek commented Sep 26, 2022

It is broken 1-2 weeks ago (spng or other PR to imgcodecs).

See nightly builds here: https://pullrequest.opencv.org/buildbot/builders/master-win64-vc14

@asmorkalov asmorkalov force-pushed the as/matcher_score_thresh branch from ccfe1a6 to 784dd55 Compare September 29, 2022 06:04
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Sep 29, 2022

@alalek The fix for runtime library warning was merged. I rebased this PR, it's ready.

@opencv-pushbot opencv-pushbot merged commit 1646a21 into opencv:4.x Oct 1, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: stitching feature

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

Do we need throw matches with high confidence in BestOf2NearestMatcher?

3 participants

@asmorkalov @alalek @opencv-pushbot