Conversation
|
Thank you! Please target this patch to "3.4" branch: https://github.com/opencv/opencv/wiki/Branches#rebasing-a-pull-request-between-branches |
| VideoWriter::fourcc('P','I','M','1') is a MPEG-1 codec, VideoWriter::fourcc('M','J','P','G') is a | ||
| motion-jpeg codec etc. List of codes can be obtained at [Video Codecs by | ||
| FOURCC](http://www.fourcc.org/codecs.php) page. FFMPEG backend with MP4 container natively uses | ||
| motion-jpeg codec etc. FFMPEG backend with MP4 container natively uses |
There was a problem hiding this comment.
I propose to replace the link with some other long-living resource like MSDN: https://docs.microsoft.com/en-us/windows/win32/medfound/video-fourccs
There was a problem hiding this comment.
long-living resource
There are tons of dead links from
microsoft.com
Anyway, content is different. So this is a wrong way.
With same effect we could place wiki page of FOURCC (which is wrong too).
22f3020 to
32dab26
Compare
|
I agree with @asmorkalov that it should be a maintained resource, but the MSDN list is much smaller. I therefore added the wayback machine link. I guess that these formats changes quite rarely and maybe fourcc has got their domain back before it becomes a problem. I can change it again if you know of other reliable maintained lists. I also rebased it onto 3.4. |
|
The link does not work for me, just redirect to main page. I think MSDN is enough for popular codecs and it gives enough info to find more values. |
|
Strange, it works for me. (and it is the same as @alalek sent above). Anyway, I changed it to MSDN per your request. |
5312b6d to
6481cfd
Compare
asmorkalov
left a comment
There was a problem hiding this comment.
👍 Thanks a lot for the contribution! I appliend addition from @catree, fixed formatting a bit and squashed commits.
Pull Request Readiness Checklist
This pull request removes a reference to a link that appears to be broken. Instead of being useful, it directs the user to some casino site. I guess that the domain owner has changed and this link should be replaced or removed entirely. I don't know what to replace it with, so I suggest removing it for now.
Patch to opencv_extra has the same branch name.
PS: I did not see anything in your contribution guidelines about fixing errors in the docs, so I did this. My apologies if this was the wrong place to notify you.