Skip to content

Fix issues in opencv_test_dnn from conv48 kernels without bias#22479

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
scottchou007:master
Sep 16, 2022
Merged

Fix issues in opencv_test_dnn from conv48 kernels without bias#22479
asmorkalov merged 1 commit intoopencv:4.xfrom
scottchou007:master

Conversation

@scottchou007
Copy link
Copy Markdown
Contributor

@scottchou007 scottchou007 commented Sep 6, 2022 •
edited by asmorkalov
Loading

Original PR: #22419

Descriptions:
The issue was found in several networks in original Opencv case "opencv_test_dnn" on NXP iMX8 ARM64 platform with Vulkan backend. It happens randomly from the networks that uses parallel convolution kernel "conv48".

Affected test: "opencv_test_dnn" with Vulkan backed (VKCOM).

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@scottchou007 scottchou007 mentioned this pull request Sep 6, 2022
Closed
6 tasks
@alalek
Copy link
Copy Markdown
Member

alalek commented Sep 6, 2022

into opencv:master

Patch should go to 4.x branch: https://github.com/opencv/opencv/wiki/Branches

@asmorkalov asmorkalov requested a review from rogday September 6, 2022 08:04
@alalek
Copy link
Copy Markdown
Member

alalek commented Sep 6, 2022

Please take a look on whitespace issues: http://pullrequest.opencv.org/buildbot/builders/precommit_docs/builds/101015

Wiki page: https://github.com/opencv/opencv/wiki/How_to_contribute#q3-i-was-asked-to-remove-whitespace-issues-how-can-i-do-that

@fengyuentau fengyuentau self-requested a review September 6, 2022 10:26
@rogday
Copy link
Copy Markdown
Member

rogday commented Sep 12, 2022

I don't see any regressions, but I also can't download all models with download_models.py (404 and stuff), so someone else should test this also since our CI doesn't test all the backends at the moment.

@asmorkalov asmorkalov changed the title Fix issues in opencv_test_dnn from conv48 kernels using uninitialized… Fix issues in opencv_test_dnn from conv48 kernels without bias Sep 13, 2022
rogday
rogday approved these changes Sep 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM, I found missing nets, looks good.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 15, 2022

@scottchou007 please squash the commits to have clean repo history.

@scottchou007 scottchou007 force-pushed the master branch 2 times, most recently from 91c9e0d to a3cb202 Compare September 15, 2022 22:09
@scottchou007
Copy link
Copy Markdown
Contributor Author

scottchou007 commented Sep 15, 2022 •
edited
Loading

Commits combined.

@asmorkalov asmorkalov merged commit e1e9261 into opencv:4.x Sep 16, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengyuentau fengyuentau Awaiting requested review from fengyuentau

1 more reviewer

@rogday rogday rogday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rogday rogday

Labels

bug category: dnn optimization

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@scottchou007 @alalek @rogday @asmorkalov