G-API: Introduce abstract base classes for GExecutor and GStreamingExecutor#22451
Merged
asmorkalov merged 2 commits intoopencv:4.xfrom Sep 9, 2022
Merged
G-API: Introduce abstract base classes for GExecutor and GStreamingExecutor#22451asmorkalov merged 2 commits intoopencv:4.xfrom
asmorkalov merged 2 commits intoopencv:4.xfrom
Conversation
GExecutor is now a subclass of GAbstractExecutor. Other to come
Now GStreamingExecutor is its subclass; others to come
| void start() override; | ||
| bool pull(cv::GRunArgsP &&outs) override; | ||
| bool pull(cv::GOptRunArgsP &&outs) override; | ||
| PyPullResult pull() override; |
Contributor
There was a problem hiding this comment.
Since GStreamingExecutor isn't exposed to python directly (only via GStreamingCompiled) it doesn't affect python, because PyPullResult matches to this API: https://github.com/opencv/opencv/blob/4.x/modules/gapi/include/opencv2/gapi/gstreaming.hpp#L277
Contributor
There was a problem hiding this comment.
Python parser knows how to parse std::tuple<bool, cv::util::variant<cv::GRunArgs, cv::GOptRunArgs>>, but don't know anything about PyPullResult which isn't used.
Contributor
|
All |
Contributor
|
@dmatveev Is the patch ready for merge? |
Contributor
Author
|
@asmorkalov yes, thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The classes are
GAbstractExecutorandGAbstractStreamingExecutor, respectively.The idea behind this simple refactoring is to introduce other execution policies (implemented by executors) in the near future.
Note: this PR replaces obsolete #21762 and #21816 -- which now can be closed.
Patch to opencv_extra has the same branch name.