Skip to content

QR code, change resize interpolation for Arm#22425

Merged
asmorkalov merged 1 commit intoopencv:3.4from
AleksandrPanov:qrcode_test_arm
Aug 29, 2022
Merged

QR code, change resize interpolation for Arm#22425
asmorkalov merged 1 commit intoopencv:3.4from
AleksandrPanov:qrcode_test_arm

Conversation

@AleksandrPanov
Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov commented Aug 24, 2022

Fixes different behavior (arm vs x86) in close_1.png

There is problem in resize() with INTER_LINEAR interpolation. There is INTER_LINEAR_EXACT interpolation to fix this. This fix breaks test with close_5.png image.

QR code in close_5.png is big and has alignment pattern, objdetect works bad with these QR codes. Different interpolation flag breaks detection.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanov AleksandrPanov added bug category: objdetect platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc labels Aug 24, 2022
@AleksandrPanov AleksandrPanov changed the title fix resize for Arm in close_1.png QR code, fix resize for Arm Aug 24, 2022
@AleksandrPanov AleksandrPanov changed the title QR code, fix resize for Arm QR code, change resize interpolation for Arm Aug 24, 2022
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AleksandrPanov AleksandrPanov marked this pull request as ready for review August 26, 2022 11:27
@AleksandrPanov
Copy link
Copy Markdown
Contributor Author

@asmorkalov, all checks have passed

@asmorkalov asmorkalov merged commit 8eb4f72 into opencv:3.4 Aug 29, 2022
@alalek alalek mentioned this pull request Oct 15, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug category: objdetect platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants