Skip to content

Suppress warnings in carotene on macOS ARM64 for 3.4 branch#22412

Merged
asmorkalov merged 2 commits intoopencv:3.4from
asenyaev:asen/carotene_warnings_macos_arm64
Aug 26, 2022
Merged

Suppress warnings in carotene on macOS ARM64 for 3.4 branch#22412
asmorkalov merged 2 commits intoopencv:3.4from
asenyaev:asen/carotene_warnings_macos_arm64

Conversation

@asenyaev
Copy link
Copy Markdown
Contributor

@asenyaev asenyaev commented Aug 22, 2022 •
edited
Loading

This PR suppress warnings in 3rdparty carotene. Examples (link):

[459/1823] Building CXX object 3rdparty/carotene/hal/carotene/CMakeFiles/carotene_objs.dir/src/add_weighted.cpp.o
/Users/opencv-cn/GHA-OCV-3/_work/ci-gha-workflow/ci-gha-workflow/opencv/3rdparty/carotene/src/add_weighted.cpp:112:28: warning: 'typename' occurs outside of a template [-Wc++11-extensions]
    void operator() (const typename VecTraits<s32>::vec128 & v_src0,
                           ^~~~~~~~~
...

[473/1823] Building CXX object 3rdparty/carotene/hal/carotene/CMakeFiles/carotene_objs.dir/src/div.cpp.o
/Users/opencv-cn/GHA-OCV-3/_work/ci-gha-workflow/ci-gha-workflow/opencv/3rdparty/carotene/src/div.cpp:93:19: warning: unused function 'divSaturate<__attribute__((neon_vector_type(2))) unsigned int>' [-Wunused-function]
inline uint32x2_t divSaturate<uint32x2_t>(const uint32x2_t &v1, const uint32x2_t &v2, const float scale)

...

[489/1823] Building CXX object 3rdparty/carotene/hal/carotene/CMakeFiles/carotene_objs.dir/src/mul.cpp.o
/Users/opencv-cn/GHA-OCV-3/_work/ci-gha-workflow/ci-gha-workflow/opencv/3rdparty/carotene/src/mul.cpp:932:18: warning: unused function 'mulSaturate<__attribute__((neon_vector_type(2))) int>' [-Wunused-function]
inline int32x2_t mulSaturate<int32x2_t>(const int32x2_t &v1, const int32x2_t &v2, const float scale)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asenyaev asenyaev mentioned this pull request Aug 22, 2022
Closed
asmorkalov
asmorkalov approved these changes Aug 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit eea05f5 into opencv:3.4 Aug 26, 2022
@asenyaev asenyaev deleted the asen/carotene_warnings_macos_arm64 branch August 26, 2022 12:49
@alalek alalek mentioned this pull request Oct 15, 2022
Merged
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@fengyuentau fengyuentau fengyuentau approved these changes

Assignees

No one assigned

Labels

category: build/install

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asenyaev @asmorkalov @fengyuentau