Skip to content

DNN: support silu activation in darknet#22410

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
zihaomu:silu_support
Aug 22, 2022
Merged

DNN: support silu activation in darknet#22410
opencv-pushbot merged 1 commit intoopencv:4.xfrom
zihaomu:silu_support

Conversation

@zihaomu
Copy link
Copy Markdown
Member

@zihaomu zihaomu commented Aug 22, 2022

Related issue #22409

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@zihaomu zihaomu linked an issue Aug 22, 2022 that may be closed by this pull request
darknet_io.cpp:250: error: (-212:Parsing error) Unsupported activation: silu in function 'setActivation' #22409
Closed
4 tasks
@asmorkalov asmorkalov requested a review from rogday August 22, 2022 06:24
rogday
rogday approved these changes Aug 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@opencv-pushbot opencv-pushbot merged commit 7831aae into opencv:4.x Aug 22, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@Izaz1
Copy link
Copy Markdown

Izaz1 commented May 16, 2023

is this issue solved

@Izaz1
Copy link
Copy Markdown

Izaz1 commented May 17, 2023

After replacing the Silu activation with Swish i am getting this error
FutureWarning: elementwise comparison failed; returning scalar instead, but in the future will perform elementwise comparison
if self.image != " ":

@zihaomu
Copy link
Copy Markdown
Member Author

zihaomu commented May 17, 2023

hi, @Izaz1, If you have any issues, please create a new one and add some details and models.

@Izaz1
Copy link
Copy Markdown

Izaz1 commented May 17, 2023 via email

@asmorkalov asmorkalov mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rogday rogday rogday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rogday rogday

Labels

category: dnn feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

darknet_io.cpp:250: error: (-212:Parsing error) Unsupported activation: silu in function 'setActivation'

5 participants

@zihaomu @Izaz1 @rogday @opencv-pushbot @asmorkalov