Skip to content

update libjpeg-turbo version to 2.1.3#22344

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
ocpalo:libjpegturbo2.1.3
Aug 12, 2022
Merged

update libjpeg-turbo version to 2.1.3#22344
opencv-pushbot merged 1 commit intoopencv:4.xfrom
ocpalo:libjpegturbo2.1.3

Conversation

@ocpalo
Copy link
Copy Markdown
Collaborator

@ocpalo ocpalo commented Aug 5, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@ocpalo ocpalo force-pushed the libjpegturbo2.1.3 branch from d882238 to 0643165 Compare August 5, 2022 20:39
@ocpalo
Copy link
Copy Markdown
Collaborator Author

ocpalo commented Aug 5, 2022

After this PR merged, i will open another PR for SIMD/NASM support for libjpeg-turbo.

@ocpalo
Copy link
Copy Markdown
Collaborator Author

ocpalo commented Aug 10, 2022

I did include assembly files in this pull request. Should I remove them and include it with SIMD/NASM support for libjpeg-turbo? I rather to keep in this pull request because they are part of the library. Let me know what you think.

@vpisarev vpisarev self-requested a review August 11, 2022 10:49
@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Aug 11, 2022

assembly files in this PR are appropriate, I think. It's atomic pull request that brings everything what is needed from libjpeg-turbo side. Next PR should update build scripts to include those assembly files into the build

@ocpalo
Copy link
Copy Markdown
Collaborator Author

ocpalo commented Aug 11, 2022

Next PR is ready. When this PR merged, i will rebase it and open it immediately.

@opencv-pushbot opencv-pushbot merged commit d09cc0f into opencv:4.x Aug 12, 2022
@alalek
Copy link
Copy Markdown
Member

alalek commented Aug 14, 2022

BTW, libjpeg-turbo 2.1.4 has been released: https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/2.1.4

@ocpalo
Copy link
Copy Markdown
Collaborator Author

ocpalo commented Aug 14, 2022

I have limited time left in order to successfully complete GSoC and I am little behind. Lets merge SIMD pr if appropiate, after GSoC, if noone does, i will update the libjpeg-turbo version.

@alalek alalek mentioned this pull request Aug 21, 2022
Merged
@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Aug 26, 2022

@ocpalo, please, submit the subsequent PR with enabling NASM in libjpeg-turbo

@ocpalo ocpalo mentioned this pull request Aug 26, 2022
Merged
6 tasks
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev vpisarev approved these changes

Assignees

@vpisarev vpisarev

Labels

category: 3rdparty

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ocpalo @vpisarev @alalek @opencv-pushbot @asmorkalov