Poll for frame data if acquisition fails after OnCaptureCompleted#22343
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Sep 19, 2022
Merged
Poll for frame data if acquisition fails after OnCaptureCompleted#22343asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
2d2b131 to
dff4f78
Compare
Contributor
|
@komakai Thanks a lot for the contribution! |
Contributor
Author
|
@asmorkalov Thanks for reviewing. In my tests it was only when getting the very first frame that polling was needed - so there was no problem with smoothness of the camera feed. But I think its a good point - I'll reduce the poll interval to 5ms |
dff4f78 to
b3adffe
Compare
Contributor
Author
|
@asmorkalov could you also review #22332 when you have a chance? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
Bugfix / Android:
On certain models (for example the OneNote 8T) grabFrame fails to obtain frame data even after an onCaptureComplete callback has been received. This PR fixes this problem by polling for frame data until we get a frame or we exceed a timeout of 2 second.