Skip to content

fix linkage issue when enable BUILD_opencv_world (#22312)#22327

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
hzcyf:4.x
Aug 2, 2022
Merged

fix linkage issue when enable BUILD_opencv_world (#22312)#22327
opencv-pushbot merged 1 commit intoopencv:4.xfrom
hzcyf:4.x

Conversation

@hzcyf
Copy link
Copy Markdown
Contributor

@hzcyf hzcyf commented Aug 1, 2022 •
edited
Loading

Fix linkage issue when enable BUILD_opencv_world

Issue

#22312

Analysis

Shlwapi.lib have not be linked.
Normally, it should be linked at modules\videoio\src\cap_msmf.cpp

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work

@zihaomu zihaomu linked an issue Aug 1, 2022 that may be closed by this pull request
Debug build fail if enable the option "BUILD_opencv_world" #22312
Closed
4 tasks
@zihaomu
Copy link
Copy Markdown
Member

zihaomu commented Aug 1, 2022

Hi @asenyaev, please check whether this PR can fix the issue of #22312.

@asenyaev
Copy link
Copy Markdown
Contributor

asenyaev commented Aug 1, 2022

Hi @zihaomu! I will check it locally and left a comment here.

@asenyaev
Copy link
Copy Markdown
Contributor

asenyaev commented Aug 1, 2022

@zihaomu, Winpack was built without any issues, the problem has disappeared.

@zihaomu zihaomu marked this pull request as ready for review August 1, 2022 08:26
@zihaomu
Copy link
Copy Markdown
Member

zihaomu commented Aug 1, 2022

@zihaomu, Winpack was built without any issues, the problem has disappeared.

Thanks!

zihaomu
zihaomu approved these changes Aug 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 👍

@asenyaev asenyaev mentioned this pull request Aug 1, 2022
Merged
@opencv-pushbot opencv-pushbot merged commit facd07a into opencv:4.x Aug 2, 2022
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zihaomu zihaomu zihaomu approved these changes

Assignees

@zihaomu zihaomu

Labels

bug category: videoio

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

Debug build fail if enable the option "BUILD_opencv_world"

5 participants

@hzcyf @zihaomu @asenyaev @opencv-pushbot @asmorkalov