Allow src=float, dst=double combination for filter2D#22256
Closed
catree wants to merge 1 commit intoopencv:3.4from
Closed
Allow src=float, dst=double combination for filter2D#22256catree wants to merge 1 commit intoopencv:3.4from
catree wants to merge 1 commit intoopencv:3.4from
Conversation
alalek
reviewed
Jul 16, 2022
Comment on lines
+3291
to
+3293
| if( sdepth == CV_32F && ddepth == CV_64F ) | ||
| return makePtr<Filter2D<float, | ||
| Cast<double, double>, FilterNoVec> >(kernel, anchor, delta); |
Member
There was a problem hiding this comment.
OpenCV library should stay efficient.
Current binary code is really large. We should not explode it by adding of extra variants.
OpenCV has 7+ basic types. So we still need to have 7 variants of implementations.
The most part of operations doesn't allow to mix input/output types - this is done for a reason.
Support of mixed types would make problem with binary size much worse:
- 2 inputs => 7*7 = 49 variants
- 3 different inputs => 343 variants
So, there is a policy to avoid processing of mixed types. Or process them through conversion to common "working" type.
If user want double accuracy, then convert inputs to doubles first.
I believe we should fix the documentation instead.
/cc @vpisarev @asmorkalov
Contributor
Contributor
Author
6 tasks
Contributor
Author
|
Replaced by #22370 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Try to fix #22242
Reading the doc, I also understand that
CV_32F/CV_64Fcombination should be allowed.