Skip to content

Define STRSAFE_NO_DEPRECATE for both clang and gcc mingw-w64#22254

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
longnguyen2004:mingw-strsafe
Jul 15, 2022
Merged

Define STRSAFE_NO_DEPRECATE for both clang and gcc mingw-w64#22254
opencv-pushbot merged 1 commit intoopencv:4.xfrom
longnguyen2004:mingw-strsafe

Conversation

@longnguyen2004
Copy link
Copy Markdown
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Changing the condition so that STRSAFE_NO_DEPRECATE is defined for both gcc and clang when building with a mingw-w64 toolchain.

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@opencv-pushbot opencv-pushbot merged commit 6fe7886 into opencv:4.x Jul 15, 2022
@longnguyen2004 longnguyen2004 deleted the mingw-strsafe branch July 16, 2022 04:11
@alalek alalek mentioned this pull request Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants