DRY (don't repeat yourself)#22232
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jul 12, 2022
Merged
Conversation
alalek
reviewed
Jul 12, 2022
Member
alalek
left a comment
There was a problem hiding this comment.
Only the first 3 changes are harmless. Others are probably not.
modules/python/CMakeLists.txt
Outdated
| else() # standalone build | ||
|
|
||
| cmake_minimum_required(VERSION 2.8.12) | ||
| cmake_minimum_required(VERSION ${MIN_VER_CMAKE}) |
Member
There was a problem hiding this comment.
standalone
MIN_VER_CMAKE may be not available for standalone bindings, samples, hal samples.
Let keep/put 2.8.12 for these cases to avoid warning.
Member
There was a problem hiding this comment.
Lets bump to 2.8.12 for other cases to avoid warning.
Contributor
Author
There was a problem hiding this comment.
I took this "other cases" as standalone bindings, samples and hal samples.
I also bumped ones in the "toolchain.cmake" in platform directory, please let me know if that's along with your expectation.
Only remaining cmake_minimum_required that I didn't touch is the one in the doc directory
DRY bump the version
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #22231
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.