Skip to content

Add missing code.#22208

Merged
alalek merged 2 commits intoopencv:3.4from
vrabaud:34_calibinit
Jul 7, 2022
Merged

Add missing code.#22208
alalek merged 2 commits intoopencv:3.4from
vrabaud:34_calibinit

Conversation

@vrabaud
Copy link
Copy Markdown
Contributor

@vrabaud vrabaud commented Jul 7, 2022

Pull Request Readiness Checklist

This code was removed in c7fc563 (#11703)
The resize was not there before but it was a alloc-ed memory with a size of quad_count

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch

This was removed in c7fc563
The resize is also a side-effect.
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

center += ci;
}
center.x *= (1.0f / quad_count);
center.y *= (1.0f / quad_count);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original idea was center *= (1.0f / quad_count);. Does it work?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes !

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@alalek alalek merged commit 0a88f84 into opencv:3.4 Jul 7, 2022
@vrabaud vrabaud deleted the 34_calibinit branch July 8, 2022 07:44
@vrabaud vrabaud mentioned this pull request Jul 12, 2022
3 tasks
@alalek alalek mentioned this pull request Jul 26, 2022
This was referenced Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants