Improve documentation of calcHist overload that accepts vectors#22189
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jul 5, 2022
Merged
Improve documentation of calcHist overload that accepts vectors#22189opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
It's not clear how ranges argument should be used in the overload of calcHist that accepts std::vector. The main overload uses array of arrays there, while std::vector overload uses a plain array. The code interprets the vector as a flattened array and rebuilds array of arrays from it. This is not obvious interpretation, so documentation has been added to explain the expected usage.
78cdb45 to
6a4c3b6
Compare
alalek
approved these changes
Jul 4, 2022
Member
alalek
left a comment
There was a problem hiding this comment.
LGTM 👍 Thank you for contribution!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.