Skip to content

Fix missing CharVector for JavaScript bindings#22173

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
ycs77:patch-2
Jul 1, 2022
Merged

Fix missing CharVector for JavaScript bindings#22173
opencv-pushbot merged 1 commit intoopencv:3.4from
ycs77:patch-2

Conversation

@ycs77
Copy link
Copy Markdown
Contributor

@ycs77 ycs77 commented Jun 29, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Copy Markdown
Member

alalek commented Jun 29, 2022 •
edited
Loading

@ycs77 Could you please clarify which function needs it?

@ycs77
Copy link
Copy Markdown
Contributor Author

ycs77 commented Jun 30, 2022 •
edited
Loading

@alalek
I want to use matchesMask arument of drawMatches() function (source), because the matchesMask argument's C++ type is std::vector<char>.

The opencv.js can be use new cv.IntVector(), new cv.KeyPointVector()... , only new cv.CharVector() is not found, but the matchesMask arument must be use the CharVector will be pass, so I added the CharVector type.

@opencv-pushbot opencv-pushbot merged commit 56e19e3 into opencv:3.4 Jul 1, 2022
@ycs77 ycs77 deleted the patch-2 branch July 1, 2022 12:25
@alalek alalek mentioned this pull request Jul 26, 2022
Closed
This was referenced Aug 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: javascript (js)

Projects

None yet

Milestone

3.4.19

Development

Successfully merging this pull request may close these issues.

3 participants

@ycs77 @alalek @opencv-pushbot