Skip to content

Fixed time value obtained on some frames at the end of the video #22141#22145

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
danopdev:issues-22141
Sep 15, 2022
Merged

Fixed time value obtained on some frames at the end of the video #22141#22145
asmorkalov merged 2 commits intoopencv:4.xfrom
danopdev:issues-22141

Conversation

@danopdev
Copy link
Copy Markdown
Contributor

@danopdev danopdev commented Jun 22, 2022 •
edited by alalek
Loading

resolves #22141

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [ x ] I agree to contribute to the project under Apache 2 License.
  • [ x ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • [ x ] The PR is proposed to the proper branch
  • [ x ] There is a reference to the original bug report and related work
  • [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • [ x ] The feature is well documented and sample code can be built with the project CMake

@danopdev danopdev mentioned this pull request Jun 22, 2022
Closed
@asmorkalov asmorkalov changed the title Issues 22141 Fixed time value obtained on some frames at the end of the video #22141 Jun 23, 2022
@danopdev
Copy link
Copy Markdown
Contributor Author

danopdev commented Jun 23, 2022

Hi @alalek

I put my test video file and source code in the original issue: #22141
How can I help for tests set ?

Regards,

@danopdev danopdev mentioned this pull request Jun 24, 2022
Merged
@asmorkalov asmorkalov self-requested a review September 15, 2022 11:30
@asmorkalov asmorkalov self-assigned this Sep 15, 2022
@asmorkalov asmorkalov added test and removed pr: needs test New functionality requires minimal tests set labels Sep 15, 2022
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 15, 2022

@danopdev I extended your PR with more precise timestamps check in existing test. Thanks a lot for the contribution!

asmorkalov
asmorkalov approved these changes Sep 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov force-pushed the issues-22141 branch 3 times, most recently from a69cf4b to b9690e4 Compare September 15, 2022 14:30
@asmorkalov asmorkalov merged commit a6017ac into opencv:4.x Sep 15, 2022
@asmorkalov asmorkalov mentioned this pull request Sep 26, 2022
Open
@asmorkalov asmorkalov mentioned this pull request Oct 11, 2022
Closed
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@alalek alalek Awaiting requested review from alalek

Assignees

@asmorkalov asmorkalov

Labels

category: videoio test

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

cv::VideoCapture - time value obtained on some frames at the end of the video is always 0

3 participants

@danopdev @asmorkalov @alalek