Skip to content

Fix Xcode version matching#22054

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
asenyaev:asen/fix_matching_xcode_version
May 31, 2022
Merged

Fix Xcode version matching#22054
opencv-pushbot merged 1 commit intoopencv:3.4from
asenyaev:asen/fix_matching_xcode_version

Conversation

@asenyaev
Copy link
Copy Markdown
Contributor

@asenyaev asenyaev commented May 30, 2022 •
edited
Loading

I've faced an issue building iOS framework on macOS. This issue happened on different devices with different python versions. It happens only with 3.4 branch.

The output:

============================================================
ERROR: cannot use a string pattern on a bytes-like object
============================================================
Traceback (most recent call last):
  File "/Users/user/test/opencv/platforms/ios/build_framework.py", line 120, in build
    self._build(outdir)
  File "/Users/user/test/opencv/platforms/ios/build_framework.py", line 88, in _build
    xcode_ver = getXCodeMajor()
  File "/Users/user/test/opencv/platforms/ios/build_framework.py", line 45, in getXCodeMajor
    m = re.match(r'Xcode\s+(\d+)\..*', ret, flags=re.IGNORECASE)
  File "/opt/homebrew/Caskroom/miniforge/base/lib/python3.9/re.py", line 191, in match
    return _compile(pattern, flags).match(string)
TypeError: cannot use a string pattern on a bytes-like object

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asenyaev asenyaev requested a review from alalek May 30, 2022 23:02
@asenyaev asenyaev mentioned this pull request May 30, 2022
Merged
@opencv-pushbot opencv-pushbot merged commit 8d51ef0 into opencv:3.4 May 31, 2022
@asenyaev asenyaev deleted the asen/fix_matching_xcode_version branch May 31, 2022 07:54
@alalek alalek mentioned this pull request Jun 4, 2022
Merged
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
@alalek alalek mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: build/install platform: ios/osx

Projects

None yet

Milestone

3.4.18

Development

Successfully merging this pull request may close these issues.

3 participants

@asenyaev @alalek @opencv-pushbot