Skip to content

Add fisheye camera model summary description with reference#22045

Merged
alalek merged 3 commits intoopencv:3.4from
victor1234:calib3d-fisheye-model-reference
May 30, 2022
Merged

Add fisheye camera model summary description with reference#22045
alalek merged 3 commits intoopencv:3.4from
victor1234:calib3d-fisheye-model-reference

Conversation

@victor1234
Copy link
Copy Markdown
Contributor

@victor1234 victor1234 commented May 27, 2022

https://stackoverflow.com/questions/31089265/what-are-the-main-references-to-the-fish-eye-camera-model-in-opencv3-0-0dev

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@victor1234 victor1234 force-pushed the calib3d-fisheye-model-reference branch from 4420ab4 to ebbff1a Compare May 27, 2022 08:04
@victor1234 victor1234 self-assigned this May 27, 2022
@victor1234 victor1234 requested a review from asmorkalov May 27, 2022 08:05
asmorkalov
asmorkalov requested changes May 27, 2022
View reviewed changes
modules/calib3d/include/opencv2/calib3d.hpp Outdated
Summary:
Generic camera model with perspective projection and without distortion correction

Kannala, Juho & Brandt, Sami. (2006). A Generic Camera Model and Calibration Method for
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it latex bib file and add reference here. See https://github.com/opencv/opencv/blob/4.x/doc/opencv.bib

Copy link
Copy Markdown
Contributor Author

@victor1234 victor1234 May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@victor1234 victor1234 force-pushed the calib3d-fisheye-model-reference branch from 61f4e93 to aeae845 Compare May 27, 2022 10:54
@asmorkalov asmorkalov self-requested a review May 30, 2022 08:58
asmorkalov
asmorkalov approved these changes May 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alalek
Copy link
Copy Markdown
Member

alalek commented May 30, 2022

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into 4.x regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: 4.x => 3.4 (use "Edit" button near PR title)
  • rebase your commits from 4.x onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/4.x
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@victor1234 victor1234 changed the base branch from 4.x to 3.4 May 30, 2022 12:16
@victor1234 victor1234 force-pushed the calib3d-fisheye-model-reference branch from aeae845 to 7759eb1 Compare May 30, 2022 14:36
@victor1234
Copy link
Copy Markdown
Contributor Author

victor1234 commented May 30, 2022

@alalek
Please check

@victor1234 victor1234 marked this pull request as ready for review May 30, 2022 15:32
@alalek alalek assigned asmorkalov and unassigned victor1234 May 30, 2022
@alalek alalek merged commit 1230075 into opencv:3.4 May 30, 2022
@victor1234 victor1234 deleted the calib3d-fisheye-model-reference branch May 30, 2022 20:17
@asmorkalov asmorkalov mentioned this pull request Jun 3, 2022
Closed
6 tasks
@alalek alalek mentioned this pull request Jun 4, 2022
Merged
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: calib3d category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.18

Development

Successfully merging this pull request may close these issues.

3 participants

@victor1234 @alalek @asmorkalov