objdetect: qrcode_encoder: fix to missing timing pattern#22030
Merged
alalek merged 2 commits intoopencv:3.4from May 31, 2022
Merged
objdetect: qrcode_encoder: fix to missing timing pattern#22030alalek merged 2 commits intoopencv:3.4from
alalek merged 2 commits intoopencv:3.4from
Conversation
alalek
reviewed
May 24, 2022
Member
alalek
left a comment
There was a problem hiding this comment.
Thank you for the fix and especially for the test!
| // (1) White margin(Left) | ||
| for(i = 0; i < white_margin ; i++ ) | ||
| { | ||
| CV_Assert( qrimg.at<uint8_t>(i, timing_pos) == 255 ) ; |
Member
There was a problem hiding this comment.
CV_Assert
Please use GoogleTest checks instead:
ASSERT_EQ(expected_value, actual_value)<< "i=" << i;
Please note about the order of parameters:
ASSERT_EQ((uint8_t)255, qrimg.at<uint8_t>(i, timing_pos)) << "i=" << i;
BTW, ASSERT_ could be replaced by EXPECT_ if there number of error messages is limited and small (we should not trash logs in case of failure).
Comment on lines
+439
to
+441
| for ( int v = min_version ; v <= max_version ; v++ ) | ||
| { | ||
| Mat qrimg; |
Member
There was a problem hiding this comment.
Please add GoogleTest's scope identifier in "for" loop body (used for error messages):
SCOPED_TRACE(cv::format("version=%d", v));
… to ASSERT_EQ(). - Add SCOPED_TRACE() for version loop. - Replace CV_Assert() to ASSERT_EQ(). - Rename expect_msg to msg.
Contributor
Author
|
Thank you for your reviewing and comment. I re-pushed commits to fix it. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
fix #22029
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.