Skip to content

Documentation Fix: Python and Java switched in Explanation#21964

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
Julian-Sz:patch-1
May 13, 2022
Merged

Documentation Fix: Python and Java switched in Explanation#21964
opencv-pushbot merged 1 commit intoopencv:3.4from
Julian-Sz:patch-1

Conversation

@Julian-Sz
Copy link
Copy Markdown
Contributor

@Julian-Sz Julian-Sz commented May 10, 2022 •
edited
Loading

On this page: https://docs.opencv.org/4.5.5/d4/d70/tutorial_hough_circle.html, in the Explanation section, the snippets for Python and Java are switched.

This bug exists in the documentation for versions 3.3.1 up to 5.0.0-pre

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added category: documentation Documentation fix or update pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch labels May 11, 2022
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 11, 2022

Thanks a lot for the contribution! Please rebase the patch to 3.4 and re-target the PR to 3.4 too. OpenCV team will merge the changes to 4.x and 5.x during regular merge procedure.

@Julian-Sz Julian-Sz changed the base branch from 4.x to 3.4 May 12, 2022 18:41
@Julian-Sz
Copy link
Copy Markdown
Contributor Author

Julian-Sz commented May 12, 2022

Did it 👍

@asmorkalov asmorkalov removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label May 13, 2022
@asmorkalov asmorkalov self-requested a review May 13, 2022 06:49
asmorkalov
asmorkalov approved these changes May 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot!

@opencv-pushbot opencv-pushbot added this to the 3.4.18 milestone May 13, 2022
@opencv-pushbot opencv-pushbot merged commit 761e796 into opencv:3.4 May 13, 2022
@opencv-pushbot opencv-pushbot mentioned this pull request May 14, 2022
Merged
@Julian-Sz Julian-Sz deleted the patch-1 branch May 21, 2022 20:41
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@opencv-pushbot opencv-pushbot

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.18

Development

Successfully merging this pull request may close these issues.

3 participants

@Julian-Sz @asmorkalov @opencv-pushbot