Skip to content

fix JpegEncoder::write#21963

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
hellodoge:imwrite_fix
May 12, 2022
Merged

fix JpegEncoder::write#21963
opencv-pushbot merged 1 commit intoopencv:3.4from
hellodoge:imwrite_fix

Conversation

@hellodoge
Copy link
Copy Markdown
Contributor

@hellodoge hellodoge commented May 9, 2022 •
edited
Loading

Hello, I encountered this kind of crash on Windows and I think I've got the solution.

3rdparty/libjpeg-turbo/src/jpeglib.h:

* NB: you must set up the error-manager BEFORE calling jpeg_create_xxx.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch (upd)
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added category: imgcodecs bug pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch labels May 11, 2022
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 11, 2022

It looks like branch 3.4 is affected too. Could you rebase the patch to 3.4. The fix will appear in 4.x during regular 3.4->4.x merge.

@hellodoge
fix JpegEncoder::write
e4ed2d2 
3rdparty/libjpeg-turbo/src/jpeglib.h:
`* NB: you must set up the error-manager BEFORE calling jpeg_create_xxx.`
@hellodoge hellodoge changed the base branch from 4.x to 3.4 May 11, 2022 10:11
@hellodoge
Copy link
Copy Markdown
Contributor Author

hellodoge commented May 11, 2022

@asmorkalov rebased

@asmorkalov asmorkalov removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label May 11, 2022
@asmorkalov asmorkalov self-requested a review May 11, 2022 10:15
@opencv-pushbot opencv-pushbot added this to the 3.4.18 milestone May 12, 2022
@opencv-pushbot opencv-pushbot merged commit 9712cc4 into opencv:3.4 May 12, 2022
@opencv-pushbot opencv-pushbot mentioned this pull request May 14, 2022
Merged
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@opencv-pushbot opencv-pushbot

Labels

bug category: imgcodecs

Projects

None yet

Milestone

3.4.18

Development

Successfully merging this pull request may close these issues.

3 participants

@hellodoge @asmorkalov @opencv-pushbot