Skip to content

fix a 3rd party blur3x3 function(the 7th value in tcurr should be set to the 5th value in old tcurr, which will be be overwritten by the 3rd value in old tcurr)#21945

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
driftee:fix-3rdparty_carotene_blur
Sep 16, 2022
Merged

Conversation

@driftee
Copy link
Copy Markdown
Contributor

@driftee driftee commented May 2, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 4, 2022

@driftee Could you provide small test/reproducer that shows the bug?

@asmorkalov asmorkalov added the platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc label May 4, 2022
@driftee
Copy link
Copy Markdown
Contributor Author

driftee commented May 5, 2022

@asmorkalov Ok, it may take me few days to write a bug report with a reproducer.

@asmorkalov asmorkalov added the bug label May 11, 2022
@asmorkalov asmorkalov added the pr: needs test New functionality requires minimal tests set label May 23, 2022
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 23, 2022

@driftee I propose to extend test "Imgproc_Blur.borderTypes" to highlight the issue and ensure the same behavior on all supported platforms. See

opencv/modules/imgproc/test/test_filter.cpp

Line 1971 in 7e845a3

TEST(Imgproc_Blur, borderTypes)

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 7, 2022

@driftee friendly reminder.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 7, 2022

The function is not called in OpenCV and cannot be tested with public API.

@asmorkalov asmorkalov removed the pr: needs test New functionality requires minimal tests set label Sep 7, 2022
@asmorkalov asmorkalov self-requested a review September 7, 2022 12:38
@asmorkalov asmorkalov self-assigned this Sep 7, 2022
@alalek
Copy link
Copy Markdown
Member

alalek commented Sep 9, 2022

@asmorkalov are you able to reproduce the problem?
Changing order of "independent" lines looks strange - if we have problem, then it could be worse.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 9, 2022

It looks like the function blur is some rudiment. It's not called from OpenCV, but Filter2d is used as universal solution. Also looks like it's not the only bug. This 2 lines are very suspicious:
https://github.com/opencv/opencv/blob/4.x/3rdparty/carotene/src/blur.cpp#L376

@asmorkalov asmorkalov merged commit 41ef2bf into opencv:4.x Sep 16, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

bug platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@driftee @asmorkalov @alalek