Skip to content

imgproc: fix two typos (imput, magnutude)#21941

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
cpoerschke:4.x-fix-imgproc-typos
May 17, 2022
Merged

imgproc: fix two typos (imput, magnutude)#21941
opencv-pushbot merged 1 commit intoopencv:4.xfrom
cpoerschke:4.x-fix-imgproc-typos

Conversation

@cpoerschke
Copy link
Copy Markdown
Contributor

@cpoerschke cpoerschke commented May 1, 2022

(Noting that based on https://github.com/opencv/opencv/wiki/Branches#which-branch-should-i-target-my-pr this pull request here could be for 3.4 instead of 4.x branch. However, it is for 4.x since 3.4 doesn't have the typos.)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@cpoerschke cpoerschke mentioned this pull request May 8, 2022
Merged
6 tasks
@asmorkalov asmorkalov added category: documentation Documentation fix or update pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch labels May 11, 2022
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 11, 2022

Thanks for the contribution. Please rebase the patch to 3.4 and retarget the pr. OpenCV team will merge it to 4.x and 4.x.

@cpoerschke
Copy link
Copy Markdown
Contributor Author

cpoerschke commented May 15, 2022

Thanks @asmorkalov for the feedback!

The intelligent scissors feature was introduced via the 3eea3dd46ba commit in the 4.5.2 release (and 3.4 doesn't have the feature or the two typos) and because of that this pull request is targetting the 4.x branch.

@asmorkalov asmorkalov removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label May 16, 2022
@asmorkalov asmorkalov self-requested a review May 16, 2022 05:52
@alalek alalek assigned asmorkalov and unassigned opencv-pushbot May 17, 2022
@opencv-pushbot opencv-pushbot merged commit 11f36bd into opencv:4.x May 17, 2022
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cpoerschke @asmorkalov @opencv-pushbot @alalek