Skip to content

Fix some typos in platforms/, samples/, 3rdparty/.#21934

Merged
asmorkalov merged 1 commit intoopencv:3.4from
Yulv-git:3.4-typos2
Sep 7, 2022
Merged

Fix some typos in platforms/, samples/, 3rdparty/.#21934
asmorkalov merged 1 commit intoopencv:3.4from
Yulv-git:3.4-typos2

Conversation

@Yulv-git
Copy link
Copy Markdown
Contributor

@Yulv-git Yulv-git commented Apr 30, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 13, 2022

Thanks for the contribution! OpenCV team does not apply fixes for 3rdparty code like libpng, libjpeg, OpenEXR, but update the component from upstream to exclude conflicts. Please reduce the patch and drop changes in non-OpenCV code.

@asmorkalov asmorkalov added category: documentation Documentation fix or update incomplete labels May 13, 2022
@asmorkalov asmorkalov self-requested a review September 7, 2022 13:12
@asmorkalov asmorkalov self-assigned this Sep 7, 2022
asmorkalov
asmorkalov approved these changes Sep 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I dropped all changes in 3rdparty as mentioned before.

@Yulv-git
Copy link
Copy Markdown
Contributor Author

Yulv-git commented Sep 7, 2022

Well, thank you!

@asmorkalov asmorkalov merged commit e243826 into opencv:3.4 Sep 7, 2022
@alalek alalek mentioned this pull request Oct 15, 2022
Merged
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.19

Development

Successfully merging this pull request may close these issues.

3 participants

@Yulv-git @asmorkalov @alalek