Skip to content

Fix KalmanFilter comment error#21916

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
chenjunnn:patch-1
May 12, 2022
Merged

Fix KalmanFilter comment error#21916
opencv-pushbot merged 1 commit intoopencv:3.4from
chenjunnn:patch-1

Conversation

@chenjunnn
Copy link
Copy Markdown
Contributor

@chenjunnn chenjunnn commented Apr 27, 2022

If there will be measurement before the next predict, statePost and errorCovPost would be assigned to updated value. So I guess these steps are meant to handle the case when no measurement and KF only do the predict step.

statePre.copyTo(statePost);
errorCovPre.copyTo(errorCovPost);

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added the category: documentation Documentation fix or update label Apr 29, 2022
@vpisarev vpisarev self-assigned this May 12, 2022
@vpisarev
Copy link
Copy Markdown
Contributor

👍

@opencv-pushbot opencv-pushbot added this to the 4.6.0 milestone May 12, 2022
If there will be measurement before the next predict, `statePost` would be assigned to updated value. So I guess these steps are meant to handle when no measurement and KF only do the predict step.
```cpp
statePre.copyTo(statePost);
errorCovPre.copyTo(errorCovPost);
```
@opencv-pushbot opencv-pushbot modified the milestones: 4.6.0, 3.4.18 May 12, 2022
@opencv-pushbot opencv-pushbot added the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label May 12, 2022
@opencv-pushbot opencv-pushbot changed the base branch from 4.x to 3.4 May 12, 2022 09:04
@opencv-pushbot opencv-pushbot removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label May 12, 2022
@opencv-pushbot opencv-pushbot removed their assignment May 12, 2022
@opencv-pushbot opencv-pushbot merged commit 40d2904 into opencv:3.4 May 12, 2022
@chenjunnn chenjunnn deleted the patch-1 branch May 12, 2022 10:38
@opencv-pushbot opencv-pushbot mentioned this pull request May 14, 2022
@alalek alalek mentioned this pull request Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: documentation Documentation fix or update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants