Skip to content

Remove an extra "not" in doc#21882

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
duanqn:improve-doc
May 12, 2022
Merged

Remove an extra "not" in doc#21882
opencv-pushbot merged 1 commit intoopencv:3.4from
duanqn:improve-doc

Conversation

@duanqn
Copy link
Copy Markdown
Contributor

@duanqn duanqn commented Apr 18, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@duanqn
Copy link
Copy Markdown
Contributor Author

duanqn commented Apr 18, 2022

Not a native English speaker, but I think removing "not" here would be clearer.

@asmorkalov asmorkalov added the category: documentation Documentation fix or update label Apr 29, 2022
@mohawk2
Copy link
Copy Markdown
Contributor

mohawk2 commented May 8, 2022

I am a native English speaker (albeit an OpenCV noob) and I agree it's both clearer and (I believe) more accurate. I read it as intending that if copyData is false, you should only deallocate after destruction of the Mat.

@opencv-pushbot opencv-pushbot added this to the 3.4.18 milestone May 12, 2022
@opencv-pushbot opencv-pushbot merged commit 2b53ab2 into opencv:3.4 May 12, 2022
@opencv-pushbot opencv-pushbot mentioned this pull request May 14, 2022
@alalek alalek mentioned this pull request Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: documentation Documentation fix or update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants