Skip to content

Added workflow for Github Actions to build and test OpenCV on Linux#21875

Merged
opencv-pushbot merged 4 commits intoopencv:3.4from
asenyaev:asen/workflow_only_linux
Apr 21, 2022
Merged

Added workflow for Github Actions to build and test OpenCV on Linux#21875
opencv-pushbot merged 4 commits intoopencv:3.4from
asenyaev:asen/workflow_only_linux

Conversation

@asenyaev
Copy link
Copy Markdown
Contributor

@asenyaev asenyaev commented Apr 15, 2022 •
edited
Loading

This PR adds a workflow for GitHub Actions to build and test OpenCV on ubuntu-20.04 for 3.4 branch

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asenyaev asenyaev changed the title Added workflow for Github Actions to build and test OpenCV Added workflow for Github Actions to build and test OpenCV on Linux for 3.4 Apr 15, 2022
@asenyaev asenyaev requested a review from asmorkalov April 15, 2022 17:10
@asenyaev
Copy link
Copy Markdown
Contributor Author

asenyaev commented Apr 18, 2022

Updated PR merging a build and tests jobs into one to reduce an amount of checks and dependencies and changing naming. This workflow is adopted for 4.x and 5.x.

@asenyaev asenyaev changed the title Added workflow for Github Actions to build and test OpenCV on Linux for 3.4 Added workflow for Github Actions to build and test OpenCV on Linux Apr 18, 2022
This was referenced Apr 18, 2022
Merged
Merged
fengyuentau
fengyuentau reviewed Apr 19, 2022
View reviewed changes
asmorkalov
asmorkalov reviewed Apr 19, 2022
View reviewed changes
@asenyaev
Renamed job names, split workflows by branch, removed and added some …
60c67f2 
…cmake flags, save unit tests results as a html file
@asmorkalov asmorkalov self-requested a review April 20, 2022 07:17
asmorkalov
asmorkalov approved these changes Apr 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done!

fengyuentau
fengyuentau reviewed Apr 20, 2022
View reviewed changes
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 20, 2022

@asenyaev Let's use JUnit XML reports for all tests, including C++, Java and Python. Github Actions can render them with this step: https://github.com/marketplace/actions/junit-report-action

@asenyaev
Copy link
Copy Markdown
Contributor Author

asenyaev commented Apr 20, 2022

@asenyaev Let's use JUnit XML reports for all tests, including C++, Java and Python. Github Actions can render them with this step: https://github.com/marketplace/actions/junit-report-action

This action just parse a xml file and add information like this:
📦 Process test results

ℹ️ 35571 tests run, 0 skipped, 0 failed.

I think it's not very useful, better to open html file. Moreover, this action adds a check for PR, what is a bit messy.

@asenyaev
Copy link
Copy Markdown
Contributor Author

asenyaev commented Apr 20, 2022 •
edited
Loading

I have a suggestion to add workflows for 4.x and 5.x branches in a separate PRs. I'll reopen and update the previous (4.x, 5.x).

@asmorkalov asmorkalov self-requested a review April 21, 2022 05:11
@fengyuentau fengyuentau added the CI/CD: GitHub Actions (GHA) Changes related to CI/CD pipelines (GitHub Actions) label Apr 21, 2022
@opencv-pushbot opencv-pushbot added this to the 3.4.18 milestone Apr 21, 2022
@opencv-pushbot opencv-pushbot merged commit a55fa83 into opencv:3.4 Apr 21, 2022
This was referenced Apr 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@fengyuentau fengyuentau fengyuentau approved these changes

Assignees

@asmorkalov asmorkalov

Labels

CI/CD: GitHub Actions (GHA) Changes related to CI/CD pipelines (GitHub Actions)

Projects

None yet

Milestone

3.4.18

Development

Successfully merging this pull request may close these issues.

4 participants

@asenyaev @asmorkalov @fengyuentau @opencv-pushbot