Skip to content

Add prefixes to layer names and layer output names#21818

Merged
alalek merged 2 commits intoopencv:3.4from
rogday:revert_renaming
May 23, 2022
Merged

Add prefixes to layer names and layer output names#21818
alalek merged 2 commits intoopencv:3.4from
rogday:revert_renaming

Conversation

@rogday
Copy link
Copy Markdown
Member

@rogday rogday commented Apr 4, 2022 •
edited
Loading

Merge with extra: opencv/opencv_extra#968
Fixes #21698

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@rogday rogday added bug category: dnn category: dnn (onnx) ONNX suport issues in DNN module labels Apr 4, 2022
@rogday rogday linked an issue Apr 4, 2022 that may be closed by this pull request
DNN/ONNX: outputs registration regression, feature request for new version of Clip operator #21698
Closed
@rogday rogday removed a link to an issue Apr 4, 2022
DNN/ONNX: outputs registration regression, feature request for new version of Clip operator #21698
Closed
@rogday rogday requested a review from alalek April 4, 2022 15:30
alalek
alalek reviewed Apr 4, 2022
View reviewed changes
@rogday rogday mentioned this pull request Apr 5, 2022
Merged
@rogday rogday force-pushed the revert_renaming branch from 3dbec2e to d324e1a Compare April 6, 2022 12:44
@rogday rogday changed the title Revert renaming of layers Add prefixes to layer names and layer output names Apr 6, 2022
@asmorkalov asmorkalov requested a review from zihaomu April 15, 2022 05:41
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 15, 2022

@zihaomu Could you review the patch and comment.

@asmorkalov asmorkalov added this to the 3.4.18 milestone Apr 15, 2022
zihaomu
zihaomu approved these changes Apr 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 25, 2022

@rogday

[  FAILED  ] Test_ONNX_layers.OutputRegistration/0, where GetParam() = OCV/CPU

@alalek alalek merged commit 93dc067 into opencv:3.4 May 23, 2022
@alalek alalek mentioned this pull request May 23, 2022
Merged
@rogday rogday deleted the revert_renaming branch May 23, 2022 20:40
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

@zihaomu zihaomu zihaomu approved these changes

Assignees

@alalek alalek

Labels

bug category: dnn (onnx) ONNX suport issues in DNN module category: dnn

Projects

None yet

Milestone

3.4.18

Development

Successfully merging this pull request may close these issues.

5 participants

@rogday @asmorkalov @alalek @zihaomu @opencv-pushbot