Skip to content

add BackgroundSubtractor(KNN|MOG2).getDefaultName() implementation#21812

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
cpoerschke:BackgroundSubtractor-getDefaultName
Apr 4, 2022
Merged

add BackgroundSubtractor(KNN|MOG2).getDefaultName() implementation#21812
opencv-pushbot merged 1 commit intoopencv:4.xfrom
cpoerschke:BackgroundSubtractor-getDefaultName

Conversation

@cpoerschke
Copy link
Copy Markdown
Contributor

Problem

The KNN and MOG2 background subtractors extend the Algorithm class but don't override the getDefaultName() method (which returns my_object).

Proposed solution

Add override for the method, avoiding the . character in the name because persistence disallows it in key names.

Usage code snippet

#include <opencv2/opencv.hpp>

int main(int argc, char* argv[])
{
    std::cout << cv::createBackgroundSubtractorKNN()->getDefaultName() << std::endl;
    cv::createBackgroundSubtractorKNN()->save("knn.algo");

    std::cout << cv::createBackgroundSubtractorMOG2()->getDefaultName() << std::endl;
    cv::createBackgroundSubtractorMOG2()->save("mog2.algo");

    return 0;
}

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@cpoerschke cpoerschke marked this pull request as ready for review April 3, 2022 20:37
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution 👍

@opencv-pushbot opencv-pushbot merged commit b2e20a8 into opencv:4.x Apr 4, 2022
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants