Skip to content

Fix MSA sum overflow issue (#19432)#21798

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
gititgo:4.x
Apr 1, 2022
Merged

Fix MSA sum overflow issue (#19432)#21798
opencv-pushbot merged 1 commit intoopencv:3.4from
gititgo:4.x

Conversation

@gititgo
Copy link
Copy Markdown
Contributor

@gititgo gititgo commented Mar 31, 2022 •
edited by alalek
Loading

resolves #19432

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
buildworker:Custom=linux-1
build_image:Custom=mips64el

@gititgo gititgo closed this Mar 31, 2022
@gititgo gititgo changed the title Fix MSA sum overflow issue #19432 Fix MSA sum overflow issue (#19432) Mar 31, 2022
@gititgo
Copy link
Copy Markdown
Contributor Author

gititgo commented Mar 31, 2022

reopen

@gititgo gititgo reopened this Mar 31, 2022
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Mar 31, 2022

/cc @seiko2plus

@alalek
Copy link
Copy Markdown
Member

alalek commented Mar 31, 2022

Thank you for contribution!

As a bugfix this patch should go into 3.4 branch first.
We will merge changes from 3.4 into 4.x regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: 4.x => 3.4 (use "Edit" button near PR title)
  • rebase your commits from 4.x onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/4.x
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@gititgo gititgo changed the base branch from 4.x to 3.4 April 1, 2022 01:42
@gititgo
Copy link
Copy Markdown
Contributor Author

gititgo commented Apr 1, 2022

I change the base to 3.4, but it shows merge from gititgo:4.x, and i can’t modify it ...

@alalek
Copy link
Copy Markdown
Member

alalek commented Apr 1, 2022

Rebased commit to 3.4 branch.

@opencv-pushbot opencv-pushbot merged commit 46b6973 into opencv:3.4 Apr 1, 2022
@alalek alalek mentioned this pull request Apr 2, 2022
Merged
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug optimization platform: other

Projects

None yet

Milestone

3.4.18

Development

Successfully merging this pull request may close these issues.

opencv_test_core FAILED --> MSA implementation of v_reduce_sum did not consider overflow

4 participants

@gititgo @asmorkalov @alalek @opencv-pushbot