Update Connected component labelling bug#21794
Conversation
|
You have modified the wrong line... |
|
I had updated it @MicheleCancilla, sorry for the previous commit. Can you take a look at it? |
|
@yash112-lang You correctly reverted the wrong change, but the original buggy line is still there. Moreover, instead of having 3 commits to fix one line of code is better to have just one (e.g. forcepushing on your repo). |
|
Edit: now it's fine! |
|
@yash112-lang Yes, after your last commit it is. To keep the history of the OpenCV repo as clean as possible, I suggest you to compress all changes (one line of code) in one single commit instead of five. |
|
@prittt, When trying to squash all commits into one it shows me an error message like this - " |
Update connectedcomponents.cpp
|
Rebased to keep 1 commit only in PR. |
alalek
left a comment
There was a problem hiding this comment.
Thank you for contribution 👍
@MicheleCancilla Thank you for the review!
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Overview
This PR fixes issue #21783