Skip to content

fix: inline namespace handling in header parser#21781

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
VadimLevin:dev/vlevin/skip-inline-namespaces
Mar 26, 2022
Merged

fix: inline namespace handling in header parser#21781
opencv-pushbot merged 1 commit intoopencv:4.xfrom
VadimLevin:dev/vlevin/skip-inline-namespaces

Conversation

@VadimLevin
Copy link
Copy Markdown
Contributor

inline namespace should be skipped in header parser namespaces list.
Example:

namespace cv {
inline namespace inlined {
namespace inner {
// content
} // namespace inner
} // namespace inlined
} // namespace cv

Before fix inner is registered as cv..inner
After fix: cv.inner

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

`inline namespace` should be skipped in header parser namespaces list.
Example:
```cpp
namespace cv {
inline namespace inlined {
namespace inner {
// content
} // namespace inner
} // namespace inlined
} // namespace cv
```
Before fix `inner` is registered as `cv..inner`
After fix: `cv.inner`
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit e4abf6e into opencv:4.x Mar 26, 2022
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants