GAPI Fluid: Enable dynamic dispatching for the Sub kernel.#21746
Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom Mar 21, 2022
Merged
GAPI Fluid: Enable dynamic dispatching for the Sub kernel.#21746opencv-pushbot merged 1 commit intoopencv:4.xfrom
opencv-pushbot merged 1 commit intoopencv:4.xfrom
Conversation
Member
anna-khakimova
commented
Mar 18, 2022
- Dynamic dispatching for Sub was enabled.
- Support of new combinations of type was added.
| int sub_simd(const SRC in1[], const SRC in2[], DST out[], const int length) \ | ||
| { \ | ||
| \ | ||
| CV_CPU_DISPATCH(sub_simd, (in1, in2, out, length), \ |
Contributor
There was a problem hiding this comment.
it apparently has incorrect indentation.
| v_uint16 a = vx_load(in1x); | ||
| v_uint32 a1 = v_expand_low(a); | ||
| v_uint32 a2 = v_expand_high(a); | ||
| v_int16 a = v_reinterpret_as_s16(vx_load(in1x)); |
Contributor
There was a problem hiding this comment.
if changes are related for dispatching functionality and adding the tag then why we've changed datatypes here?
Member
Author
There was a problem hiding this comment.
It is a fix for issue.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.