cartToPolar/polarToCart: disable inplace mode#21739
Merged
opencv-pushbot merged 2 commits intoopencv:3.4from Mar 21, 2022
Merged
cartToPolar/polarToCart: disable inplace mode#21739opencv-pushbot merged 2 commits intoopencv:3.4from
opencv-pushbot merged 2 commits intoopencv:3.4from
Conversation
alalek
reviewed
Mar 18, 2022
modules/core/test/test_arithm.cpp
Outdated
| } | ||
| } | ||
|
|
||
| using namespace ocl; |
Contributor
Author
There was a problem hiding this comment.
I think EXPECT_MAT_NEAR did not work without it. I'll check.
Contributor
Author
There was a problem hiding this comment.
I've checked and it is EXPEC_MAT_NEAR which requires ocl namespace.
Member
There was a problem hiding this comment.
Could we use related calls with full namespace in this macro?
Contributor
Author
There was a problem hiding this comment.
Done! Also rebased to 3.4.
aa3c55e to
69822cf
Compare
69822cf to
5939962
Compare
4 tasks
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #21732
Raise an exception if one of sources is the same as one of destinations since inplace mode works incorrectly (with and without IPP).