Conversation
|
Hi @rogday, How is the PR progress so far? Maybe I can do something if you want. |
|
Hi @zihaomu, I think we need to wait for merge of @fengyuentau's extra blobs info so that we can reuse it for 1-d and 0-d support here. Otherwise I think it's pretty much done. |
|
Hello @rogday , we came across the problem of lacking support for gather op with multiple indices. I wonder if you have time working on this pull request. If no, me or someone on my side can help you finish this pull request. |
Hi! Sorry for the delay. I'll give it a shot next week. Would you be okay with that? |
Sure, no problem. Thank you! In case you need a ONNX model for testing, here is the one I used: gather_multiple_indices.onnx.zip. It is the same operator that dnn does support in the model as mentioned above, and is generated with my script. |
63c9d76 to
05cff0f
Compare
fengyuentau
left a comment
There was a problem hiding this comment.
Could we turn on some onnx conformance tests of gather? Others look good to me
Unfortunately no - type(integer indices) and shape(less than 2d) issues in non-const context aren't handled by this PR. |
Merge with extra: opencv/opencv_extra#1007
Should resolve #20439, resolve #19957
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.